Handle download in pdf preview #503
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sacha Al Himdani <[email protected]>
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
1 issue found across 2 files
Prompt for AI agents (all 1 issues)
Understand the root cause of the following 1 issues and fix them.
<file name="apps/console/src/components/documents/PDFPreview.tsx">
<violation number="1" location="apps/console/src/components/documents/PDFPreview.tsx:78">
Programmatic download fails in browsers like Firefox because the anchor is never added to the DOM before click(). Attach it to document.body before triggering the click and remove it afterward.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
| const link = document.createElement("a"); | ||
| link.href = src; | ||
| link.download = name || "document.pdf"; | ||
| link.click(); |
There was a problem hiding this comment.
Programmatic download fails in browsers like Firefox because the anchor is never added to the DOM before click(). Attach it to document.body before triggering the click and remove it afterward.
Prompt for AI agents
Address the following comment on apps/console/src/components/documents/PDFPreview.tsx at line 78:
<comment>Programmatic download fails in browsers like Firefox because the anchor is never added to the DOM before click(). Attach it to document.body before triggering the click and remove it afterward.</comment>
<file context>
@@ -71,6 +71,13 @@ export function PDFPreview({ src, name }: { src: string; name?: string }) {
+ const link = document.createElement("a");
+ link.href = src;
+ link.download = name || "document.pdf";
+ link.click();
+ };
+
</file context>
Contributor
Author
There was a problem hiding this comment.
It works fine in firefox
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Added a proper download action to the PDF preview toolbar in Console and Trust. Clicking the inbox icon now downloads the PDF using the name prop (fallback: document.pdf) instead of zooming.
Written for commit 7da20b0. Summary will update automatically on new commits.